(Editorial) Expanded on the note on algorithm names #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iherman
requested review from
msporny,
martyr280,
Wind4Greg and
seabass-labrax
as code owners
Wind4Greg
approved these changes
Aug 12, 2024
TallTed
requested changes
Aug 12, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
TallTed
reviewed
Aug 13, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
TallTed
approved these changes
Aug 14, 2024
msporny
approved these changes
Aug 17, 2024
msporny
added
the
CR1
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change is based on implementation experience: the difference between
secp256r1andsecp256k1is not alway appearent for application developers (who are not seasoned crypto developers). This change tries to help a bit.Preview | Diff