Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove windsurf related selective disclosure example. Fix formatting. #96

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

Wind4Greg
Copy link
Collaborator

@Wind4Greg Wind4Greg commented Jan 23, 2025

This PR addresses issues #86, #95, and #90. These are changes to non-normative text.

  1. It addresses the "inline context" issue by removing the only test vector example that used this feature.
  2. It addresses the "formatting issue" by hand formatting the generated test vector JSON files.
  3. It addresses the "who is responsible for generating..." issue by removing the unfamiliar and confusing windsurf example. All other selective disclosure examples indicate issuer are creating base proof and holder the derived proof in the test vector text.

Preview | Diff

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little sad to see it go ... but it's for the best it seems.

@msporny msporny added editorial The item is editorial in nature. CR2 This item was processed during the second Candidate Recommendation Phase labels Jan 26, 2025
@msporny
Copy link
Member

msporny commented Jan 26, 2025

Purely editorial, merging.

@msporny msporny merged commit 4c9e449 into w3c:main Jan 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR2 This item was processed during the second Candidate Recommendation Phase editorial The item is editorial in nature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants