Update act-rules-format.bs for secondary req and acc support #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Secondary requirements and accessibility support conclusion
tbostic32
reviewed
Aug 31, 2023
act-rules-format/act-rules-format.bs
Outdated
| @@ -226,6 +226,7 @@ A secondary accessibility requirement is a requirement that is correlated with t | |||
|
|
|||
| When the rule is not designed to test the accessibility requirement, or failed outcomes of the rule still require further testing for the accessibility requirement, the rule <em class="rfc2119">may</em> map the accessibility requirement as Secondary. When an ACT rule maps to a Secondary requirement, it <em class="rfc2119">must</em> include an explanation of why that requirement is Secondary in the Background section of the rule. | |||
|
|
|||
| When the rule is designed to test an accessibility requirement, limitations or differences in [accessibility support](#accessibility-support) shall not be a reason for that requirement to be a secondary accessibility requirement. | |||
There was a problem hiding this comment.
Should we replace "shall" with either "should" or "must"?
daniel-montalvo
previously requested changes
Sep 4, 2023
act-rules-format/act-rules-format.bs
Outdated
| @@ -226,6 +226,7 @@ A secondary accessibility requirement is a requirement that is correlated with t | |||
|
|
|||
| When the rule is not designed to test the accessibility requirement, or failed outcomes of the rule still require further testing for the accessibility requirement, the rule <em class="rfc2119">may</em> map the accessibility requirement as Secondary. When an ACT rule maps to a Secondary requirement, it <em class="rfc2119">must</em> include an explanation of why that requirement is Secondary in the Background section of the rule. | |||
|
|
|||
| When the rule is designed to test an accessibility requirement, limitations or differences in [accessibility support](#accessibility-support) shall not be a reason for that requirement to be a secondary accessibility requirement. | |||
act-rules-format/act-rules-format.bs
Outdated
Comment on lines
229
to
230
| When the rule is designed to test an accessibility requirement, limitations or differences in [accessibility support](#accessibility-support) shall not be a reason for that requirement to be a secondary accessibility requirement. | ||
|
|
There was a problem hiding this comment.
Not sure about the word "limitations" here. Does not "differences" express by itself what we mean here?
kengdoj
commented
Sep 12, 2023
kengdoj
changed the title
daniel-montalvo
approved these changes
Sep 26, 2023
tbostic32
approved these changes
Sep 28, 2023
WilcoFiers
approved these changes
Nov 9, 2023
WilcoFiers
reviewed
Nov 30, 2023
Co-authored-by: Wilco Fiers <[email protected]>
tombrunet
approved these changes
Nov 30, 2023
github-actions bot
added a commit
that referenced
this pull request
Nov 30, 2023
SHA: 8ea041a Reason: push, by daniel-montalvo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 30, 2023
SHA: 8ea041a Reason: push, by daniel-montalvo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Secondary requirements and accessibility support conclusion from act-rules/act-rules.github.io#2095