Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify TPM attestation verification instructions #1926

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Clarify TPM attestation verification instructions #1926

merged 1 commit into from
Sep 24, 2024

Conversation

sbweeden
Copy link
Contributor

@sbweeden sbweeden commented Jul 18, 2023 •
edited by pr-preview bot
Loading

Addresses #1925

Preview | Diff

@sbweeden sbweeden linked an issue Jul 18, 2023 that may be closed by this pull request
TPM attestation verification steps inconsistent with FIDO conformance testing tool #1925
Closed
emlun
emlun previously requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is incorrect as is - see my response in #1925 (comment).

@nadalin nadalin added the @Risk Items that are at risk for L3 label Nov 29, 2023
@timcappalli
Copy link
Member

timcappalli commented Jan 31, 2024 •
edited
Loading

@timcappalli and @dturnerx to ask Monty Wiseman from FIDO

@mwiseman-byid can you take a look?

@sbweeden sbweeden mentioned this pull request Mar 5, 2024
Closed
@yackermann
Copy link
Contributor

LGTM

@mwiseman-byid
Copy link
Contributor

I'm traveling today, will review by EOD 2024-06-17

@sbweeden
Copy link
Contributor Author

@dturnerx - Can you please check with the FIDO conformance team to see if they are willing to drop the test case that uses two different keys? There has been no evidence provided to suggest that in the wild two different keys will ever ben used.

selfissued
selfissued approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a valuable clarification.

@nadalin nadalin added this to the L3-WD-02 milestone Sep 11, 2024
@emlun emlun dismissed their stale review September 24, 2024 16:11

WG consensus in favour of the change

timcappalli
timcappalli approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicksteele nicksteele merged commit 199dcda into w3c:main Sep 24, 2024
github-actions bot added a commit that referenced this pull request Sep 24, 2024
@nicksteele @github-actions
Merge pull request #1926 from sbweeden/sbweeden_1925
2e28186 
SHA: 199dcda
Reason: push, by nicksteele

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayku akshayku akshayku approved these changes

@selfissued selfissued selfissued approved these changes

@timcappalli timcappalli timcappalli approved these changes

@MasterKale MasterKale MasterKale approved these changes

@emlun emlun emlun left review comments

Assignees

@akshayku akshayku

Labels
@Risk Items that are at risk for L3 type:technical
Projects
None yet
Milestone
L3-WD-02
Development

Successfully merging this pull request may close these issues.

TPM attestation verification steps inconsistent with FIDO conformance testing tool
10 participants
@sbweeden @timcappalli @yackermann @mwiseman-byid @emlun @MasterKale @selfissued @akshayku @nicksteele @nadalin