Clarify validation step for packed attestation certificate for RPs. #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
This seems fair to me. But I also wonder, could we perhaps solve this with less text? I'm thinking if we re-order the steps of the verification procedure like so:
- If attestnCert contains an extension with OID
1.3.6.1.4.1.45724.1.1.4(id-fido-gen-ce-aaguid) verify that the value of this extension matches theaaguidin authenticatorData.- Verify that attestnCert meets the requirements in § 8.2.1 Packed Attestation Statement Certificate Requirements.
and then add "other" to the latter step like so:
- Verify that attestnCert meets the other requirements in § 8.2.1 Packed Attestation Statement Certificate Requirements.
Would that suffice to clarify the issue?
agreed Co-authored-by: Emil Lundberg <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Nov 29, 2023
SHA: 065b836 Reason: push, by sbweeden Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1998
Preview | Diff