Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bikeshed lint #2015

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Fix Bikeshed lint #2015

merged 2 commits into from
Jan 10, 2024

Conversation

emlun
Copy link
Member

@emlun emlun commented Jan 10, 2024

  • Remove autolink to nonexistent term "WebAuthn credentials"
  • Delete unused term "client-side discoverable credential property"

Fixes these Bikeshed lints:

LINE ~8667: No 'dfn' refs found for 'webauthn credentials'.
[=WebAuthn credentials=]
LINT: Unexported dfn that's not referenced locally - did you mean to export it?
<dfn data-dfn-type="dfn" data-dfn-for="CredentialPropertiesOutput" id="credentialpropertiesoutput-client-side-discoverable-credential-property" data-lt="client-side discoverable credential property" data-noexport="by-default">client-side discoverable credential property<a href="#credentialpropertiesoutput-client-side-discoverable-credential-property" class="self-link"></a></dfn>
<dfn data-dfn-type="dfn" data-dfn-for="CredentialPropertiesOutput" id="credentialpropertiesoutput-client-side-discoverable-credential-property" data-lt="client-side discoverable credential property" data-noexport="by-default">client-side discoverable credential property<a href="#credentialpropertiesoutput-client-side-discoverable-credential-property" class="self-link"></a></dfn>

Preview | Diff

emlun added 2 commits January 10, 2024 14:32
Fixes this Bikeshed lint:

```
LINE ~8667: No 'dfn' refs found for 'webauthn credentials'.
[=WebAuthn credentials=]
```
Fixes this Bikeshed lint:

```
LINT: Unexported dfn that's not referenced locally - did you mean to export it?
<dfn data-dfn-type="dfn" data-dfn-for="CredentialPropertiesOutput" id="credentialpropertiesoutput-client-side-discoverable-credential-property" data-lt="client-side discoverable credential property" data-noexport="by-default">client-side discoverable credential property<a href="#credentialpropertiesoutput-client-side-discoverable-credential-property" class="self-link"></a></dfn>
<dfn data-dfn-type="dfn" data-dfn-for="CredentialPropertiesOutput" id="credentialpropertiesoutput-client-side-discoverable-credential-property" data-lt="client-side discoverable credential property" data-noexport="by-default">client-side discoverable credential property<a href="#credentialpropertiesoutput-client-side-discoverable-credential-property" class="self-link"></a></dfn>
```
@emlun emlun self-assigned this Jan 10, 2024
@nadalin nadalin added this to the L3-WD-02 milestone Jan 10, 2024
Copy link
Contributor

@ve7jtb ve7jtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicksteele nicksteele self-requested a review January 10, 2024 20:28
@emlun emlun merged commit 82db709 into main Jan 10, 2024
2 checks passed
@nicksteele nicksteele removed their request for review January 10, 2024 20:28
@emlun emlun deleted the fix-lint branch January 10, 2024 20:28
github-actions bot added a commit that referenced this pull request Jan 10, 2024
SHA: 82db709
Reason: push, by emlun

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants