Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Say that tokenBinding is RESERVED in History #2239

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Say that tokenBinding is RESERVED in History #2239

merged 1 commit into from
Jan 22, 2025

Conversation

selfissued
Copy link
Contributor

@selfissued selfissued commented Jan 20, 2025 •
edited by pr-preview bot
Loading

timcappalli
timcappalli approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unnecessary given:

This section summarizes the significant changes

but sure.

@selfissued
Copy link
Contributor Author

Significant is in the eye of the beholder. A major multinational client was just asking me about using Token Binding during TPAC, saying that it looked like it would satisfy the requirements of their use case. I had to break it to them that it's not likely to ever be deployable in practice.

@selfissued selfissued merged commit 51c239f into w3c:main Jan 22, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request Jan 22, 2025
@selfissued @github-actions
Merge pull request #2239 from selfissued/mbj-tokenBinding-RESERVED
5618709 
SHA: 51c239f
Reason: push, by selfissued

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@emlun
Copy link
Member

emlun commented Jan 22, 2025

Agreed - token binding may have been inconsequential in practice, but its deprecation is a significant (as in not just editorial) change to the WebAuthn API.

@rlin1 rlin1 mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadalin nadalin nadalin approved these changes

@timcappalli timcappalli timcappalli approved these changes

@MasterKale MasterKale MasterKale approved these changes

@emlun emlun emlun approved these changes

@ve7jtb ve7jtb Awaiting requested review from ve7jtb

@simoneonofri simoneonofri Awaiting requested review from simoneonofri

@sbweeden sbweeden Awaiting requested review from sbweeden

@akshayku akshayku Awaiting requested review from akshayku

Assignees
No one assigned
Labels
priority:high type:editorial
Projects
None yet
Milestone
L3 Candidate Recommendation
Development

Successfully merging this pull request may close these issues.
5 participants
@selfissued @emlun @MasterKale @timcappalli @nadalin