Better CDDL for session.SubscriptionRequest
#679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Mar 6, 2024
|
Waiting for another vendor to approve and I will create a PR before merging this. |
whimboo
approved these changes
Mar 7, 2024
|
Opened - web-platform-tests/wpt#44985 |
github-actions bot
added a commit
that referenced
this pull request
Mar 7, 2024
SHA: a676958 Reason: push, by Lightning00Blade Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
OrKoN
pushed a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting from #628. As I think this make sense regardless of the outcome of that PR.
Motivation here is that the algorithms for both empty cases become no-op if the lists are empty -
For events:
Update the event map
Step 5 -> Step 7.1.1 is looped over a empty list.
For Contexts:
Update the event map
Step 5 -> Step 8.3.2 is looped over a empty list.
The part about
contexts: []becomes consistent withaddPreloadScriptandaddInterceptionas they both fail on empty list.Preview | Diff