Try to ensure sandboxed preload scripts run in the correct realm #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were passing the environment settings object for the Window realm into `evaluate function body`, which is incorrect. Instead update `environment settings` to point to the environment settings object for the sandboxed realm. Also have a go at defining the steps to create a sandboxed realm and ensure that it has an environment settings object that we can use.
juliandescottes
approved these changes
Sep 9, 2024
OrKoN
reviewed
Oct 29, 2024
| @@ -1257,8 +1257,55 @@ To <dfn>get or create a sandbox realm</dfn> given |name| and |navigable|: | |||
| <div algorithm> | |||
| To <dfn>create a sandbox realm</dfn> with |window|: | |||
|
|
|||
| Issue: Define creation of sandbox realm. This is going to return a | |||
| {{SandboxWindowProxy}} wrapping |window|. | |||
| 1. Let |window environment settings| be the [=environment settings object=] whose | |||
There was a problem hiding this comment.
By looking at call sites of "create a sandbox realm" the argument should be navigable, so probably we need the env settings object of |navigable|'s [=active window=].
|
|
||
| <dt>The [=environment settings object/module map=] | ||
| <dd>Return |global|'s module map. | ||
| Issue: Need to define module map for {{SandboxWindowProxy}} objects. |
There was a problem hiding this comment.
Looks like this issue is not rendered properly? Perhaps it needs newlines or needs to be outside of dl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were passing the environment settings object for the Window realm into
evaluate function body, which is incorrect.Instead update
environment settingsto point to the environment settings object for the sandboxed realm.Also have a go at defining the steps to create a sandboxed realm and ensure that it has an environment settings object that we can use.
Preview | Diff