-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow applying preload scripts to opened contexts #803
Draft
OrKoN
wants to merge
2
commits into
main
Choose a base branch
from
orkon/preload-script-inheritance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
377aa58
to
b13c1de
Compare
This needs new tests as well, right? |
jgraham
requested changes
Oct 29, 2024
The Browser Testing and Tools Working Group just discussed The full IRC log of that discussion<AutomatedTester> topic: Allow applying preload scripts to opened contexts<AutomatedTester> github: https://github.com//pull/803 <AutomatedTester> orkon: this is one of the. topics that was brought up by the playwright folks <jgraham> q+ <AutomatedTester> ... this is the PR that prepared to implements inheritance for preload scripts <sadym> q+ <AutomatedTester> ... I wonder if there are concerns with this approach and would this have an issue with the events being sent out? <AutomatedTester> ack next <AutomatedTester> jgraham: I think we shouild do this <AutomatedTester> ... we should be looking to add global configuration or top level traversibles be documented <AutomatedTester> ... I agree we should be doing this but I think we need to be aware of all the different ways that we should bve doing this <AutomatedTester> q? <AutomatedTester> ack next <AutomatedTester> sadym: this looks like a new mechanism. I wonder if this playwright appraoch could not be handled with using preload script globally <AutomatedTester> jgraham: I think it could but that might be harder <AutomatedTester> ... people would want it a per context and I think we want it inheritable. They are both required <AutomatedTester> q? |
I assume the original issue is addressed by #862 |
As we discussed in the WG meeting, we likely want to have both features but the user context feature has more priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows specifying that a specific preload script should apply not only to the specified contexts and but also to all contexts opened by the specified contexts (recursively).
Issue #756
Preview | Diff