fix: typo approache -> the … approach #2070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
approved these changes
Jan 11, 2025
TallTed
suggested changes
Jan 14, 2025
Comment on lines
+7599
to
7601
| described in <code>cancellation</code>. Alternatively, the <code>uriVariables</code> approach can be used that | ||
| informs the <a>Consumer</a> to include the <code>subscriptionID</code> string into the URI that have to be | ||
| called with the delete method (see tab 'With uriVariables'). In such setup, the |
There was a problem hiding this comment.
Suggested change
| described in <code>cancellation</code>. Alternatively, the <code>uriVariables</code> approach can be used that | |
| informs the <a>Consumer</a> to include the <code>subscriptionID</code> string into the URI that have to be | |
| called with the delete method (see tab 'With uriVariables'). In such setup, the | |
| described in <code>cancellation</code>. Alternatively, a <code>uriVariables</code> approach, that | |
| informs the <a>Consumer</a> to include the <code>subscriptionID</code> string in the URIs that have to be | |
| called with the delete method (see tab 'With uriVariables'), can be used. In such setup, the |
There was a problem hiding this comment.
Rather complex sentence 😏. Maybe we can add commas.
Alternatively, a uriVariables approach >,< that informs the Consumer to include the subscriptionID string in the URIs that have to be called with the delete method (see tab 'With uriVariables') >,< can be used
There was a problem hiding this comment.
Good fix, @danielpeintner. Commas added to my change suggestion. (I had contemplated adding em-dashes to the same effect.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2066
Preview | Diff