Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo approache -> the … approach #2070

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -10591,7 +10591,7 @@ <h3>Webhook Event Example</h3>
<code>subscriptionID</code> is returned by the subscription. The <i>TemperatureSensor</i> will then
periodically POST to this callback URI with a payload defined by <code>data</code>. To unsubscribe, the
<a>Consumer</a> has to submit the <code>unsubscribeevent</code> form with the <code>subscriptionID</code> as
described in <code>cancellation</code>. Alternatively, <code>uriVariables</code> approache can be used that
described in <code>cancellation</code>. Alternatively, the <code>uriVariables</code> approach can be used that
informs the <a>Consumer</a> to include the <code>subscriptionID</code> string into the URI that have to be
called with the delete method (see tab 'With uriVariables'). In such setup, the
<code>cancellation</code> container can be obmitted. In general, this example can be further automated by
Expand Down
2 changes: 1 addition & 1 deletion index.template.html
Original file line number Diff line number Diff line change
Expand Up @@ -7596,7 +7596,7 @@ <h3>Webhook Event Example</h3>
<code>subscriptionID</code> is returned by the subscription. The <i>TemperatureSensor</i> will then
periodically POST to this callback URI with a payload defined by <code>data</code>. To unsubscribe, the
<a>Consumer</a> has to submit the <code>unsubscribeevent</code> form with the <code>subscriptionID</code> as
described in <code>cancellation</code>. Alternatively, <code>uriVariables</code> approache can be used that
described in <code>cancellation</code>. Alternatively, the <code>uriVariables</code> approach can be used that
informs the <a>Consumer</a> to include the <code>subscriptionID</code> string into the URI that have to be
called with the delete method (see tab 'With uriVariables'). In such setup, the
Comment on lines +7599 to 7601
Copy link
Member

@TallTed TallTed Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
described in <code>cancellation</code>. Alternatively, the <code>uriVariables</code> approach can be used that
informs the <a>Consumer</a> to include the <code>subscriptionID</code> string into the URI that have to be
called with the delete method (see tab 'With uriVariables'). In such setup, the
described in <code>cancellation</code>. Alternatively, a <code>uriVariables</code> approach, that
informs the <a>Consumer</a> to include the <code>subscriptionID</code> string in the URIs that have to be
called with the delete method (see tab 'With uriVariables'), can be used. In such setup, the

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather complex sentence 😏. Maybe we can add commas.

Alternatively, a uriVariables approach >,< that informs the Consumer to include the subscriptionID string in the URIs that have to be called with the delete method (see tab 'With uriVariables') >,< can be used

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, @danielpeintner. Commas added to my change suggestion. (I had contemplated adding em-dashes to the same effect.)

<code>cancellation</code> container can be obmitted. In general, this example can be further automated by
Expand Down
Loading