Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Polkadot JS sections Pt. 1 #5340

Merged
merged 17 commits into from
Nov 9, 2023
Merged

Edit Polkadot JS sections Pt. 1 #5340

merged 17 commits into from
Nov 9, 2023

Conversation

filippoweb3
Copy link
Contributor

@filippoweb3 filippoweb3 commented Nov 3, 2023

  • Leave Polkadot JS stuff in the Advanced Section only, remove mentions in General and Basic.
  • Add a warning banner to JS pages and guides

@filippoweb3 filippoweb3 added the A1 - In Progress Not ready for review yet. label Nov 3, 2023
@filippoweb3 filippoweb3 self-assigned this Nov 3, 2023
@filippoweb3 filippoweb3 changed the title Edit Polkadot JS sections Edit Polkadot JS sections Pt. 1 Nov 8, 2023
@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. A0 - Do Not Merge Pull request should not yet be merged. and removed A1 - In Progress Not ready for review yet. labels Nov 8, 2023
@filippoweb3 filippoweb3 requested a review from laboon November 8, 2023 07:06
Copy link
Contributor

@laboon laboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, minor comments

docs/general/how-to-dyor.md Outdated Show resolved Hide resolved
@filippoweb3 filippoweb3 merged commit aba6f18 into master Nov 9, 2023
2 checks passed
@filippoweb3 filippoweb3 deleted the edits-polkadot-js branch November 9, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - Do Not Merge Pull request should not yet be merged. A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "warning box" to all sections detailing instructions with Polkadot-JS
2 participants