-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Polkadot JS sections Pt. 1 #5340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
filippoweb3
commented
Nov 3, 2023
•
edited
Loading
edited
- Leave Polkadot JS stuff in the Advanced Section only, remove mentions in General and Basic.
- Add a warning banner to JS pages and guides
- Polkadot-JS guides - descriptions, etc
- deleted js mention (not necessary)
filippoweb3
added
A2 - Please Review
Pull request is ready for review.
A0 - Do Not Merge
Pull request should not yet be merged.
and removed
A1 - In Progress
Not ready for review yet.
labels
Nov 8, 2023
laboon
requested changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, minor comments
Co-authored-by: Bill Laboon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A0 - Do Not Merge
Pull request should not yet be merged.
A2 - Please Review
Pull request is ready for review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.