Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Parathreads -> On-demand Parachains #5858

Merged
merged 24 commits into from
May 7, 2024
Merged

Conversation

filippoweb3
Copy link
Contributor

@filippoweb3 filippoweb3 commented May 2, 2024

  • Rm parathread page (update sidebar and add redirects) and move content to learn-parachains
  • Swap parathread -> on-demand parachains
  • Make sure there is a connection between on-demand parachains and Agile Coretime

@filippoweb3 filippoweb3 added the A1 - In Progress Not ready for review yet. label May 2, 2024
@filippoweb3 filippoweb3 self-assigned this May 2, 2024
@filippoweb3 filippoweb3 linked an issue May 2, 2024 that may be closed by this pull request
@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels May 3, 2024
@filippoweb3
Copy link
Contributor Author

@CrackTheCode016 let me know if these changes make sense to you. See the attached issue by @Overkillus

Copy link
Contributor

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good refactor, thank you! We can further improve more of the explainations in further PRs, but this is really great to clarify right now 🙏

The only reason I did not approve was the use of the word "permanent" - I'm not sure it is entirely accurate, perhaps it would be better to allude to bulk coretime instead. However, I could be wrong here.

docs/general/faq.md Outdated Show resolved Hide resolved
docs/general/faq.md Outdated Show resolved Hide resolved
docs/general/glossary.md Outdated Show resolved Hide resolved
docs/learn/learn-guides-coretime-marketplaces.md Outdated Show resolved Hide resolved
docs/learn/learn-transactions.md Outdated Show resolved Hide resolved
less scalable, and parathreads in particular may not receive messages due to excessive queue
growth.
less scalable, and on-demand parachains in particular may not receive messages due to excessive
queue growth.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious if this is indeed the case, not sure how queue is managed in relation to on-demand (I suspect it's the same, still good to check probably though)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, I did not touch that sentence if not just for swapping parathread <-> on-demand parachain

@filippoweb3
Copy link
Contributor Author

filippoweb3 commented May 6, 2024

@CrackTheCode016 I implemented your feedback. Added @DrW3RK as a secondary reviewer to provide final feedback before merging.

Copy link
Contributor

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall fine, thanks! I see that "permanent" is still being used in a few places, however I will leave the final review to Radha to decide.

docs/build/build-data.md Outdated Show resolved Hide resolved
docs/build/build-guide.md Outdated Show resolved Hide resolved
docs/build/build-guide.md Outdated Show resolved Hide resolved
docs/build/build-parachains.md Outdated Show resolved Hide resolved
docs/build/build-parachains.md Outdated Show resolved Hide resolved
docs/learn/learn-parachains.md Outdated Show resolved Hide resolved
docs/learn/learn-parachains.md Outdated Show resolved Hide resolved
docs/learn/learn-parachains.md Outdated Show resolved Hide resolved
docs/learn/learn-parachains.md Outdated Show resolved Hide resolved
docs/learn/learn-parachains.md Outdated Show resolved Hide resolved
@filippoweb3
Copy link
Contributor Author

@DrW3RK thanks for the final review. I noticed you added coretime in a few pages although not deployed on Polkadot yet. I approved all suggestions and there will be a few places still mentioning auctions. Resolved a few conflicts and merging this.

@filippoweb3 filippoweb3 merged commit 13fa395 into master May 7, 2024
3 checks passed
@filippoweb3 filippoweb3 deleted the edits-parathreads branch May 7, 2024 11:35
@DrW3RK
Copy link
Member

DrW3RK commented May 7, 2024

Right. Considering these docs also render on the Kusama guide, I mentioned coretime where necessary (especially, with on-demand parachains which only make sense with coretime in picture). We can change those to conditionally render through a follow-up PR (if it is worth the effort) or wait till Agile Coretime goes live on Polkadot to just eliminate all the references to slots/leases when.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parathreads clarifications
3 participants