Enable Unit Tests to Pass on PR Submissions from Forked Repos #1744
AlexDickersonAnnotations
10 warnings
|
Test (windows-latest):
Wabbajack.Paths.IO/KnownFolders.cs#L16
Unreachable code detected
|
|
Test (windows-latest):
Wabbajack.Downloaders.VerificationCache/VerificationCache.cs#L47
Nullability of reference types in return type of 'Task<(bool?, IDownloadState?)> VerificationCache.Get(IDownloadState archive)' doesn't match implicitly implemented member 'Task<(bool? IsValid, IDownloadState State)> IVerificationCache.Get(IDownloadState archive)'.
|
|
Test (windows-latest):
Wabbajack.Downloaders.VerificationCache/NullCache.cs#L7
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Test (windows-latest):
Wabbajack.Common/FileSignatures/SignatureChecker.cs#L33
Avoid inexact read with 'System.IO.Stream.ReadAsync(System.Memory<byte>, System.Threading.CancellationToken)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
|
|
Test (windows-latest):
Wabbajack.Compression.BSA/DirectXTexUtil.cs#L522
A possible null value may not be used for a type marked with
|
|
Test (windows-latest):
Wabbajack.Compression.BSA/BA2Archive/DX10Entry.cs#L34
The field 'DX10Entry._unk16' is never used
|
|
Test (windows-latest):
Wabbajack.Compression.BSA/BA2Archive/FileEntry.cs#L71
Avoid inexact read with 'System.IO.Stream.ReadAsync(System.Memory<byte>, System.Threading.CancellationToken)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
|
|
Test (windows-latest):
Wabbajack.Compression.BSA/BA2Archive/DX10Entry.cs#L141
Avoid inexact read with 'System.IO.Stream.ReadAsync(System.Memory<byte>, System.Threading.CancellationToken)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
|
|
Test (windows-latest):
Wabbajack.Compression.BSA/BA2Archive/DX10Entry.cs#L146
Avoid inexact read with 'System.IO.Stream.ReadAsync(System.Memory<byte>, System.Threading.CancellationToken)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
|
|
Test (windows-latest):
Wabbajack.Hashing.PHash/TexConvImageLoader.cs#L158
The variable 'ex' is declared but never used
|