Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faster file download approach #2672

Closed
Closed
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
069ba2b
Replace usage of ResumableDownloader with NonReusableDownloader for f…
AlexDickerson Dec 27, 2024
dc6847e
Reverted unneeded change to AInstaller
AlexDickerson Dec 27, 2024
28a7f4e
Added more explicit error logging
AlexDickerson Dec 27, 2024
861e7df
Synced Namespaces
AlexDickerson Dec 27, 2024
44fe695
Adding UI for setting minimum file size at which to use resumable dow…
AlexDickerson Dec 28, 2024
fa7b2a0
Reverting unintended changes
AlexDickerson Dec 28, 2024
5ef9812
Reverting unneeded changes
AlexDickerson Dec 28, 2024
c25f439
Remove deprecated nexus auth method
AlexDickerson Dec 28, 2024
e8eff20
Merge pull request #2673 from AlexDickerson/removeSetNexusAPI
tr4wzified Dec 28, 2024
54863c6
Refactored performance settings and its dependency injection
AlexDickerson Dec 28, 2024
e8fa2be
Replaced references to concrete SettingsManager with interface
AlexDickerson Dec 28, 2024
76cd4dc
Removed two unnecessary usings
AlexDickerson Dec 28, 2024
f0d8b64
Fixed DownloadClientFactory to compare file size correctly
AlexDickerson Dec 28, 2024
66545cd
One more cleanup pass
AlexDickerson Dec 28, 2024
5ff915c
Replace usage of ResumableDownloader with NonReusableDownloader for f…
AlexDickerson Dec 27, 2024
4120d41
Reverted unneeded change to AInstaller
AlexDickerson Dec 27, 2024
d6ec4b2
Added more explicit error logging
AlexDickerson Dec 27, 2024
6fc715a
Synced Namespaces
AlexDickerson Dec 27, 2024
c87b302
Adding UI for setting minimum file size at which to use resumable dow…
AlexDickerson Dec 28, 2024
19c7583
Reverting unintended changes
AlexDickerson Dec 28, 2024
2fcad64
Reverting unneeded changes
AlexDickerson Dec 28, 2024
2d77b12
Refactored performance settings and its dependency injection
AlexDickerson Dec 28, 2024
7c73b24
Replaced references to concrete SettingsManager with interface
AlexDickerson Dec 28, 2024
31626cf
Removed two unnecessary usings
AlexDickerson Dec 28, 2024
a3bbcbf
Fixed DownloadClientFactory to compare file size correctly
AlexDickerson Dec 28, 2024
192c34b
One more cleanup pass
AlexDickerson Dec 28, 2024
7dd4ac7
Merge branch 'downloadsRefactor' of https://github.com/AlexDickerson/…
AlexDickerson Dec 28, 2024
a3e9016
Refactored downloader to resume on network failures
AlexDickerson Dec 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed DownloadClientFactory to compare file size correctly
AlexDickerson committed Dec 28, 2024
commit a3bbcbfa78dc499230f2971684a4cc9d5f1cc93a
2 changes: 1 addition & 1 deletion Wabbajack.Downloader.Clients/DownloadClientFactory.cs
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ public class DownloadClientFactory(MainSettings _settings, ILoggerFactory _logge

public IDownloadClient GetDownloader(HttpRequestMessage msg, AbsolutePath outputPath, IJob job)
{
if (job.Size >= _settings.MinimumFileSizeForResumableDownloadMB)
if (job.Size >= _settings.MinimumFileSizeForResumableDownloadMB * 1024 * 1024)
{
return new ResumableDownloadClient(msg, outputPath, job, _settings.MaximumMemoryPerDownloadThreadInMB, _resumableDownloaderLogger);
}