소셜 로그인 연동 #319
Open
소셜 로그인 연동 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shp7724
reviewed
Nov 19, 2024
Comment on lines
+10
to
+16
| struct SocialProvider { | ||
| var local: Bool | ||
| var facebook: Bool | ||
| var google: Bool | ||
| var kakao: Bool | ||
| var apple: Bool | ||
| } |
There was a problem hiding this comment.
Q. 이 필드중에 여러개가 true일 가능성도 있는건가?
There was a problem hiding this comment.
웅 여러개 연동 되어있으면 전부 true!
Comment on lines
21
to
23
| func detachKakao() async { | ||
| do { | ||
| try await services.userService.disconnectKakao() |
There was a problem hiding this comment.
detach, disconnect 용어 통일하는게 어때
There was a problem hiding this comment.
오키 다 disconnect로 해야겠다
Comment on lines
+37
to
+39
| // if (viewModel.currentSocialProvider?.apple == true) { | ||
| // SettingsButtonItem(title: "애플 계정 연동 해제", role: .destructive) { | ||
| // isDisconnectAppleAlertPresented = true |
There was a problem hiding this comment.
이건 서버쪽에서 애플로그인 남은 작업 있어서 일단 주석해놓고 PR 먼저 올린걸로 알고있으
| func detachGoogle() async { | ||
| do { | ||
| try await services.userService.disconnectGoogle() | ||
| try await services.userService.fetchSocialProvider() |
There was a problem hiding this comment.
Q. disconnect 하고 fetchSocialProvider를 호출하는 이유가 뭐야?
There was a problem hiding this comment.
연동 해제하면 UI가 '연동 해제' -> '연동'으로 바뀌어야해서 서버에서 계정 상태 한번 더 불러오고 있어
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구글 & 카카오 계정 연동 추가