Fix Github Actions for Ubuntu 24.04 base image #160
Conversation
Stormheg
force-pushed
the
chore/fix-ci
branch
from
e2f014c to
cca7273
Compare
Stormheg
changed the title
Stormheg
force-pushed
the
chore/fix-ci
branch
from
cca7273 to
729335e
Compare
Github actions has now defaulted to using its Ubuntu 24.04 base image. Compared to the previous base image, this is missing many pre-installed binaries. Such as imagemagick. Comparison: - Ubuntu 24.04: https://github.com/actions/runner-images/blob/ubuntu24/20241215.1/images/ubuntu/Ubuntu2404-Readme.md - Ubuntu 22.04: https://github.com/actions/runner-images/blob/ubuntu24/20241215.1/images/ubuntu/Ubuntu2204-Readme.md
Stormheg
force-pushed
the
chore/fix-ci
branch
from
729335e to
a1b8439
Compare
|
Not sure what causes the CI to fail... Can't seem to reproduce this locally in a Ubuntu 24.04 docker container. |
Stormheg
force-pushed
the
chore/fix-ci
branch
from
fce6cd6 to
65d846a
Compare
Stormheg
force-pushed
the
chore/fix-ci
branch
from
65d846a to
7fced76
Compare
| run: | | ||
| sudo apt-get update -y | ||
| # For Wand tests | ||
| sudo apt-get install -y imagemagick |
There was a problem hiding this comment.
given 22.04 has imagemagick, do we want this?
There was a problem hiding this comment.
or.. perhaps try installing libmagick++-dev libmagickcore-dev libmagickwand-dev in addition to imagemagick on 24.04?
There was a problem hiding this comment.
@zerolab I tried to ascertain that the test suite does pass on on 22.04, which it does. That manual install is leftover from trying to fix the 24.04 build.
Not sure why it is failing on 24.04. I know that 24.04 does not ship with ImageMagick installed, so we do that manually. That does not help however, there is something wrong where it fails somewhat silently by returning None.
I'd like to get to the bottom of this, but don't have a lot of capacity to invest at the moment. Perhaps we should pin the workflow to 22.04 for now so the testsuite continues working and create an issue to move to 24.04
There was a problem hiding this comment.
let's do that. solve the immediate problem, then spend more time looking into 24.04
|
Closing this in favor of stop-gap #162 |
Github actions has now defaulted to using its Ubuntu 24.04 base image.
Compared to the previous base image, this is missing many pre-installed
binaries. Such as imagemagick.
Comparison: