Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Images with different file formats #506

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Morsey187
Copy link
Contributor

Issue: #457

Description

Images used within the initial data (populated via load_initial_data) only contain file formats jpg or jpeg, this PR aims to add additonal formats to help with testing as described in #457.

I've aimed to add new images in each individual commit to help with reviewing as well as updating images specific to ones that appear under the “blog” section on the Home page, which should make for easier testing.

Screenshot 2024-09-12 at 14 53 30

Testing notes

I’d recommened flushing your database and setting up the project from scratch using load_intial_data, then reviewing the site and page editor.

Notes

  • I think SVG support should be added in a seperate PR, keen to keep discussions in relation to this in the original Issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue:

  1. The site has a 10.0 MB upload restriction, although likely sensible, finding a lightweight copyright free giff (or video we can convert to a giff) is surprisingly difficult. I found this one here https://pixabay.com/videos/bread-cut-slice-preparation-starch-209418/ and had to shorten and compress the giff multiple times to get it under the 10.0mb limit.
  2. The giff is compressed down to a bad quality and arguably rather confusing contextually (it's on the "The Greatest Thing Since Sliced Bread" page).
Screenshot 2024-09-16 at 10 12 05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant