Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIB-29: Encourage more verbose shoutouts #240

Open
wants to merge 5 commits into
base: VIB-1
Choose a base branch
from
Open

VIB-29: Encourage more verbose shoutouts #240

wants to merge 5 commits into from
+35 −28

Conversation

PivtoranisV
Copy link
Collaborator

@PivtoranisV PivtoranisV commented Feb 4, 2025 •
edited by pull-request-badge bot
Loading

VIB-29 Powered by Pull Request Badge

Hello Team, please review PR

Description:

  • Updated logic for disabling the 'send shoutout' button
  • Add a message if the user types less than two words
  • Fixed issue with the wrong position of the dropdown list

Screenshots:

Screenshot 2025-02-03 at 17 01 58 Screenshot 2025-02-03 at 17 03 17 Screenshot 2025-02-03 at 17 02 41

@PivtoranisV PivtoranisV added the review needed Code reviews needed by the minimum number of developers required label Feb 4, 2025
@PivtoranisV PivtoranisV self-assigned this Feb 4, 2025
@rogergraves rogergraves added review done Code reviews are completed by the minimum number of developers required ready for testing Ready for QA to test locally or on a test server and removed review needed Code reviews needed by the minimum number of developers required labels Feb 4, 2025
@PivtoranisV PivtoranisV added do not merge Do not merge this branch into master and removed ready for testing Ready for QA to test locally or on a test server labels Feb 5, 2025
@rogergraves rogergraves added the merge conflicts A developer needs to resolve current merge conflicts label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogergraves rogergraves rogergraves approved these changes

@valvolyk valvolyk valvolyk approved these changes

@Maryna-Harasko Maryna-Harasko Awaiting requested review from Maryna-Harasko

Assignees

@PivtoranisV PivtoranisV

Labels
do not merge Do not merge this branch into master merge conflicts A developer needs to resolve current merge conflicts review done Code reviews are completed by the minimum number of developers required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PivtoranisV @rogergraves @valvolyk