[v3] Fix service name determination #3827
Conversation
WalkthroughThe pull request updates the project's changelog and modifies the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Should use service instance, not Service wrapper struct.
windom
force-pushed
the
v3/service-name
branch
from
e8f8e26
to
6088501
Compare
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
mkdocs-website/docs/en/changelog.md (1)
24-24: LGTM! Consider adding more details about the fix.The new entry correctly documents the fix for service name determination, which aligns with the PR objectives. Well done on keeping the changelog up-to-date!
Consider adding a brief explanation of the issue that was fixed, such as:
- Fixed service name determination by [windom](https://github.com/windom/) in [#3827](https://github.com/wailsapp/wails/pull/3827) + Fixed service name determination in `Application.New` method by [windom](https://github.com/windom/) in [#3827](https://github.com/wailsapp/wails/pull/3827)This provides more context about the specific component that was affected by the fix.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
- mkdocs-website/docs/en/changelog.md (1 hunks)
- v3/pkg/application/application.go (1 hunks)
🧰 Additional context used
🔇 Additional comments (2)
mkdocs-website/docs/en/changelog.md (1)
Line range hint
1-24: Excellent changelog structure and consistency!The changelog is well-organized, following the Keep a Changelog format consistently. It provides clear and detailed information about changes across different versions, including contributor credits and PR references. This level of detail greatly helps users and developers understand the project's evolution.
v3/pkg/application/application.go (1)
145-145: Approved: Fix for service name determinationThis change correctly modifies how the service name is retrieved when logging an error during the
OnStartupmethod of a service. By passingservice.instanceinstead ofserviceto thegetServiceNamefunction, it ensures that the actual service instance is used for name determination, which aligns with the PR objective.This modification should resolve any issues related to incorrect service name determination in error logs.
Description
Currently
Application.Newdetermines service name wrongly, because it callsgetServiceName()on theapplication.Servicestruct instead of the wrapped service instance. This simple fix corrects that.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor.Test Configuration
Please paste the output of
wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdxwith details of this PRSummary by CodeRabbit
New Features
Bug Fixes
Improvements
Documentation