Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add js-waku encryption guide #145

Merged
merged 13 commits into from
Jan 11, 2024
Merged

add js-waku encryption guide #145

merged 13 commits into from
Jan 11, 2024

Conversation

LordGhostX
Copy link
Contributor

@LordGhostX LordGhostX commented Dec 6, 2023

Tackles some of the tasks in #125

preview: https://docs-waku-org-git-js-encryption-acidinfo.vercel.app/guides/js-waku/message-encryption

pending:

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-waku-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 9:40am

docs/guides/js-waku/message-encryption.md Outdated Show resolved Hide resolved
docs/guides/js-waku/message-encryption.md Show resolved Hide resolved
docs/guides/js-waku/message-encryption.md Show resolved Hide resolved
docs/guides/js-waku/message-encryption.md Show resolved Hide resolved
docs/guides/js-waku/message-encryption.md Outdated Show resolved Hide resolved
docs/guides/js-waku/message-encryption.md Outdated Show resolved Hide resolved
};
```

## Restoring encryption keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is necessary//useful.

However, do feel free to use https://github.com/waku-org/js-waku-examples/tree/master/examples/eth-pm/src/key_pair_handling as an example on how to save/restore key information from local storage using proper security (Subtle Crypto)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the key_pair_handling example, but I still think the bytesToHex and hexToBytes examples are helpful for some key exporting use cases. Let me know what you think about the update

Copy link
Member

@vpavlin vpavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, otherwise looks great to me!

@LordGhostX LordGhostX merged commit e2ec02d into develop Jan 11, 2024
3 checks passed
@LordGhostX LordGhostX deleted the js-encryption branch January 11, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants