Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select peer to dial from drop down #282

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

adklempner
Copy link
Member

No description provided.

@adklempner adklempner force-pushed the adklempner/248-light-js-debugging-tool branch 2 times, most recently from 6a11881 to c8a849e Compare October 30, 2023 20:37
@adklempner adklempner marked this pull request as ready for review October 30, 2023 20:37
@adklempner adklempner requested a review from a team as a code owner October 30, 2023 20:37
@adklempner adklempner force-pushed the adklempner/248-light-js-debugging-tool branch from c8a849e to a70c28d Compare October 31, 2023 02:37
// Queries all peers from store and updates list of connected peers
const updatePeersList = async () => {
// Generate <p> element with connection string from each peer
const peers = await node.store.peers();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node.store refers to Store protocol and though it seems to be possible to get peers from there we should try using connectionManager or libp2p directly.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use node.libp2p.peerStore

<label for="remote-multiaddr">Remote peer's multiaddr</label>
</div>
<div>
<input id="remote-multiaddr" type="text" value="" style="width: 100%" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's add some styling - this field is soooo long :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a right margin to parent div and made the maximum width for the input 900px; this is about as wide it needs to be to display the entire multiaddr

Copy link
Contributor

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats with first PR 🎉

@weboko weboko merged commit 2f455c1 into master Nov 2, 2023
9 checks passed
@weboko weboko deleted the adklempner/248-light-js-debugging-tool branch November 2, 2023 11:54
@fryorcraken
Copy link
Collaborator

Is that related to a specific issue?

@adklempner
Copy link
Member Author

it checks off 3 of the boxes listed as requirements for this issue: #248 (comment)

@fryorcraken
Copy link
Collaborator

it checks off 3 of the boxes listed as requirements for this issue: #248 (comment)

Ah great. I recommend to mention the issue in the description of PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants