-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: select peer to dial from drop down #282
Conversation
6a11881
to
c8a849e
Compare
c8a849e
to
a70c28d
Compare
examples/light-js/index.html
Outdated
// Queries all peers from store and updates list of connected peers | ||
const updatePeersList = async () => { | ||
// Generate <p> element with connection string from each peer | ||
const peers = await node.store.peers(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use node.libp2p.peerStore
examples/light-js/index.html
Outdated
<label for="remote-multiaddr">Remote peer's multiaddr</label> | ||
</div> | ||
<div> | ||
<input id="remote-multiaddr" type="text" value="" style="width: 100%" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: let's add some styling - this field is soooo long :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a right margin to parent div and made the maximum width for the input 900px; this is about as wide it needs to be to display the entire multiaddr
a70c28d
to
2391874
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats with first PR 🎉
Is that related to a specific issue? |
it checks off 3 of the boxes listed as requirements for this issue: #248 (comment) |
Ah great. I recommend to mention the issue in the description of PRs. |
No description provided.