Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove lab.waku.org related examples #295

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

weboko
Copy link
Contributor

@weboko weboko commented Jan 8, 2024

No description provided.

@weboko weboko requested a review from a team as a code owner January 8, 2024 23:40
@weboko
Copy link
Contributor Author

weboko commented Jan 8, 2024

@hackyguru @vpavlin, please, review.

@danisharora099
Copy link
Contributor

@waku-org/eco-dev we intend to move web-chat to https://github.com/waku-org/lab.waku.org -- please feel free to decide the examples you would prefer to keep within examples.

@danisharora099 danisharora099 requested a review from a team January 10, 2024 08:55
@vpavlin
Copy link
Member

vpavlin commented Jan 22, 2024

Looks good to me. I think it is ok to remove web-chat from example.waku.org - we don't want people to build unencrypted chat apps anyway:)

@hackyguru hackyguru self-requested a review January 23, 2024 06:52
@hackyguru
Copy link
Collaborator

+1, it's better to remove web-chat from examples

@weboko
Copy link
Contributor Author

weboko commented Jan 23, 2024

@fryorcraken need help with dropping required steps of the examples that will be removed. I don't have needed access

@fryorcraken
Copy link
Collaborator

@weboko done

@weboko weboko merged commit 427db17 into master Feb 14, 2024
3 checks passed
@weboko weboko deleted the weboko/lab-update branch February 14, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants