setup dynamic polyfill for node env

waku-org · Apr 18, 2024 · e30bc95 · e30bc95
1 parent e5e8cd5
commit e30bc95
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 46 deletions.
diff --git a/.cspell.json b/.cspell.json
@@ -63,6 +63,7 @@
     "libp",
     "lightpush",
     "livechat",
+    "localstorage",
     "Merkle",
     "mkdir",
     "mplex",

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/discovery/package.json b/packages/discovery/package.json
@@ -59,7 +59,8 @@
     "debug": "^4.3.4",
     "dns-query": "^0.11.2",
     "hi-base32": "^0.5.1",
-    "uint8arrays": "^5.0.1"
+    "uint8arrays": "^5.0.1",
+    "node-localstorage": "^3.0.5"
   },
   "devDependencies": {
     "@libp2p/peer-id": "^4.0.4",
@@ -75,7 +76,6 @@
     "chai-as-promised": "^7.1.1",
     "cspell": "^8.6.1",
     "mocha": "^10.3.0",
-    "node-localstorage": "^3.0.5",
     "npm-run-all": "^4.1.5",
     "rollup": "^4.12.0",
     "sinon": "^17.0.1"

diff --git a/packages/discovery/src/local-peer-cache/index.spec.ts b/packages/discovery/src/local-peer-cache/index.spec.ts
@@ -17,16 +17,6 @@ import { LocalPeerCacheDiscovery } from "./index.js";
 
 chai.use(chaiAsPromised);
 
-// dynamically importing the local storage polyfill for node
-if (typeof window === "undefined") {
-  try {
-    const { LocalStorage } = await import("node-localstorage");
-    global.localStorage = new LocalStorage("./scratch");
-  } catch (error) {
-    console.error("Failed to load localStorage polyfill:", error);
-  }
-}
-
 const mockPeers = [
   {
     id: "16Uiu2HAm4v86W3bmT1BiH6oSPzcsSr24iDQpSN5Qa992BCjjwgrD",

diff --git a/packages/discovery/src/local-peer-cache/index.ts b/packages/discovery/src/local-peer-cache/index.ts
@@ -28,6 +28,16 @@ export const DEFAULT_LOCAL_TAG_NAME = Tags.LOCAL;
 const DEFAULT_LOCAL_TAG_VALUE = 50;
 const DEFAULT_LOCAL_TAG_TTL = 100_000_000;
 
+// dynamically importing the local storage polyfill for node environments
+if (typeof window === "undefined") {
+  try {
+    const { LocalStorage } = await import("node-localstorage");
+    global.localStorage = new LocalStorage("./mock-localstorage");
+  } catch (error) {
+    log.error("Failed to load localStorage polyfill:", error);
+  }
+}
+
 export class LocalPeerCacheDiscovery
   extends TypedEventEmitter<PeerDiscoveryEvents>
   implements PeerDiscovery, Startable