Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: start using REST in e2e tests #1826

Closed
Tracked by #140
weboko opened this issue Feb 5, 2024 · 0 comments · Fixed by #1856
Closed
Tracked by #140

feat: start using REST in e2e tests #1826

weboko opened this issue Feb 5, 2024 · 0 comments · Fixed by #1856
Assignees
@adklempner
Labels
E:js-waku JSON RPC Deprecation test Issue related to the test suite with no expected consequence to production code

Comments

@weboko
Copy link
Collaborator

weboko commented Feb 5, 2024

This is a change request

Problem

JSON RPC will be deprecated and REST endpoints do not have any e2e test coverage

Proposed Solutions

Use REST endpoints in packages/tests to:

  • fetch needed info;
  • check amount of messages etc;
  • send messages from nwaku nodes;

I believe we should perceive REST endpoints as ready to use but be cautious of appearing bugs - so that there will be someone involved from nwaku.

Notes

Relevant to: waku-org/pm#125
@weboko weboko added test Issue related to the test suite with no expected consequence to production code E:Comprehensive dev testing See https://github.com/waku-org/pm/issues/90 for details labels Feb 5, 2024
@weboko weboko added this to Waku Feb 5, 2024
@weboko weboko moved this to Triage in Waku Feb 5, 2024
@weboko weboko mentioned this issue Feb 5, 2024
Closed
3 tasks
@adklempner adklempner self-assigned this Feb 14, 2024
@adklempner adklempner moved this from Triage to In Progress in Waku Feb 14, 2024
@chair28980 chair28980 mentioned this issue Feb 14, 2024
Closed
1 task
@chair28980 chair28980 added E:js-waku JSON RPC Deprecation and removed E:Comprehensive dev testing See https://github.com/waku-org/pm/issues/90 for details labels Feb 14, 2024
This was referenced Feb 15, 2024
Merged
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Feb 19, 2024
@adklempner adklempner mentioned this issue Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adklempner adklempner

Labels
E:js-waku JSON RPC Deprecation test Issue related to the test suite with no expected consequence to production code
Projects
Waku
Archived in project
[Milestone] JSON RPC Deprecation
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: migrates e2e tests to use rest instead of rpc waku-org/js-waku
3 participants
@adklempner @chair28980 @weboko