Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Milestone] JSON RPC Deprecation #125

Closed
3 tasks done
chair28980 opened this issue Feb 5, 2024 · 4 comments
Closed
3 tasks done

[Milestone] JSON RPC Deprecation #125

chair28980 opened this issue Feb 5, 2024 · 4 comments

Comments

@chair28980
Copy link
Contributor

chair28980 commented Feb 5, 2024

Milestone: https://github.com/waku-org/pm/milestone/14

Summary

Deprecate nwaku and go-waku JSON RPC API and replace its usage with REST API across the repos (tests).

Epics

@weboko
Copy link

weboko commented Feb 5, 2024

On js-waku side we already dropped testing against go-waku and the only way we use JSON RPC is by retrieving some info or making nwaku do something from end-to-end tests that are in place.

It should be safe to switch to REST but there are some risks involved:

Transition should be cautious and might need some back and forth with nwaku team.

Task for js-waku to work on - waku-org/js-waku#1826

@chair28980
Copy link
Contributor Author

Scope signed-off during EU-NA pm 2024-02-19.

@chair28980
Copy link
Contributor Author

@fryorcraken @jm-clius should we add a task here for removing json-rpc spec from RFCs?

@jm-clius
Copy link

jm-clius commented Mar 7, 2024

@chair28980 yes, thank you!

@chair28980 chair28980 moved this to In Progress in Waku Mar 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in [Milestone] JSON RPC Deprecation Apr 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Apr 19, 2024
@chair28980 chair28980 removed the Deliverable Tracks a Deliverable label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants