feat: optimistically create streams for light protocols #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danisharora099
commented
Aug 30, 2023
size-limit report 📦
|
danisharora099
force-pushed
the
feat/optimistic-streams
branch
from
ba290ec
to
c269e6d
Compare
fryorcraken
reviewed
Aug 31, 2023
|
|
||
| export class StreamManager { | ||
| private streamsPool: Map<string, Stream[]> = new Map(); | ||
| private ongoingStreamCreations: Map<string, Promise<Stream>> = new Map(); |
There was a problem hiding this comment.
I would make it simpler by not having a "pool" of stream, but just one stream.
Also, once you created a stream, I'd just store the Promise<Stream> and that's it. and just return this promise
| } | ||
|
|
||
| this.log(`No stream available for peer ${peerIdStr}. Opening a new one.`); | ||
| return this.createAndSaveStream(peer); |
There was a problem hiding this comment.
you dont need to "create and save", you just need to return a fresh new stream
Comment on lines
+69
to
+70
| const peerStreams = this.streamsPool.get(peerIdStr) || []; | ||
| peerStreams.push(stream); |
There was a problem hiding this comment.
I am pretty sure this could be your race condition. Not 100% sure how it work with the JavaScript event loop.
Maybe @weboko can advise.
In any case, I would not have a array of stream, just have 1
|
closing in favour of #1516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! not to be merged -- optimisations and testing to be done !!
Results:
Thoughts/TODOs:
StreamManagerto increase readability