Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove try catch no longer needed after 1790 got fixed #2026

Merged
merged 1 commit into from
May 30, 2024

Conversation

fbarbu15
Copy link
Collaborator

Problem

Solution

Notes

  • Resolves
  • Related to

Contribution checklist:

  • covered by unit tests;
  • covered by e2e test;
  • add ! in title if breaks public API;

Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 181.41 KB (0%) 3.7 s (0%) 16.3 s (-45.67% 🔽) 19.9 s
Waku Simple Light Node 181.43 KB (0%) 3.7 s (0%) 20.6 s (+2.31% 🔺) 24.2 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 7.3 s (+31.52% 🔺) 7.8 s
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 3.8 s (+22.23% 🔺) 4.3 s
DNS discovery 72.49 KB (0%) 1.5 s (0%) 11.9 s (-32.61% 🔽) 13.4 s
Peer Exchange discovery 74.15 KB (0%) 1.5 s (0%) 13.5 s (+1.17% 🔺) 15 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 19.4 s (-32.57% 🔽) 20.8 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 5.6 s (-60.76% 🔽) 6.4 s
Waku Filter 111.92 KB (0%) 2.3 s (0%) 15.2 s (+13.85% 🔺) 17.4 s
Waku LightPush 110.39 KB (0%) 2.3 s (0%) 27 s (+52.64% 🔺) 29.2 s
History retrieval protocols 110.91 KB (0%) 2.3 s (0%) 11.5 s (-33.78% 🔽) 13.8 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 2 s (-56.91% 🔽) 2.1 s

@fbarbu15 fbarbu15 marked this pull request as ready for review May 30, 2024 13:24
@fbarbu15 fbarbu15 requested a review from a team as a code owner May 30, 2024 13:24
Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@danisharora099 danisharora099 merged commit c5302fd into master May 30, 2024
10 of 11 checks passed
@danisharora099 danisharora099 deleted the chore/remove-try-catch-for-1790 branch May 30, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants