Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporarily remove peer cross dependencies #2123

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Sep 5, 2024

Problem

release-please does not bump peer dependencies for @waku/* packages.

Solution

Remove peer dependencies for now before #2063 is done.

@weboko weboko requested a review from a team as a code owner September 5, 2024 08:23
Copy link

github-actions bot commented Sep 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 82.82 KB (0%) 1.7 s (0%) 8 s (+56.34% 🔺) 9.7 s
Waku Simple Light Node 134.62 KB (0%) 2.7 s (0%) 8 s (+32.61% 🔺) 10.7 s
ECIES encryption 22.94 KB (0%) 459 ms (0%) 2.8 s (-22% 🔽) 3.2 s
Symmetric encryption 22.39 KB (0%) 448 ms (0%) 1.9 s (+63.73% 🔺) 2.4 s
DNS discovery 72.38 KB (0%) 1.5 s (0%) 5.4 s (+7.56% 🔺) 6.8 s
Peer Exchange discovery 73.73 KB (0%) 1.5 s (0%) 6.5 s (-6.06% 🔽) 8 s
Local Peer Cache Discovery 67.63 KB (0%) 1.4 s (0%) 5.8 s (+37.57% 🔺) 7.2 s
Privacy preserving protocols 74.8 KB (0%) 1.5 s (0%) 7 s (+28.51% 🔺) 8.5 s
Waku Filter 78.06 KB (0%) 1.6 s (0%) 4.3 s (-45.84% 🔽) 5.8 s
Waku LightPush 75.58 KB (0%) 1.6 s (0%) 6.3 s (+42.55% 🔺) 7.8 s
History retrieval protocols 75.96 KB (0%) 1.6 s (0%) 4.8 s (-38.35% 🔽) 6.3 s
Deterministic Message Hashing 7.38 KB (0%) 148 ms (0%) 525 ms (-51.77% 🔽) 673 ms

@weboko weboko merged commit f4b6bb0 into master Sep 5, 2024
10 of 11 checks passed
@weboko weboko deleted the weboko/remove-peer-deps branch September 5, 2024 22:45
@weboko weboko mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants