Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to WALA 1.6.4 #174

Merged
merged 10 commits into from
Mar 29, 2024
Merged

Upgrade to WALA 1.6.4 #174

merged 10 commits into from
Mar 29, 2024

Conversation

khatchad
Copy link
Collaborator

Test issue wala/WALA#1377.

@khatchad khatchad mentioned this pull request Mar 23, 2024
Closed
@khatchad khatchad marked this pull request as draft March 26, 2024 15:38
@khatchad khatchad marked this pull request as ready for review March 27, 2024 16:56
@khatchad khatchad requested a review from msridhar March 27, 2024 16:56
@khatchad khatchad enabled auto-merge (squash) March 27, 2024 16:56
@msridhar
Copy link
Member

Generally I don't think it's great to rely on a SNAPSHOT version. Then some errant commit to WALA could break the build here. Should I just cut a 1.6.4 release and we can rely on that?

@khatchad
Copy link
Collaborator Author

Sure. That should work.

@khatchad khatchad marked this pull request as draft March 28, 2024 13:50
auto-merge was automatically disabled March 28, 2024 13:50

Pull request was converted to draft

@khatchad khatchad changed the title Upgrade to WALA 1.6.4-SNAPSHOT Upgrade to WALA 1.6.4 Mar 28, 2024
@khatchad
Copy link
Collaborator Author

Generally I don't think it's great to rely on a SNAPSHOT version. Then some errant commit to WALA could break the build here. Should I just cut a 1.6.4 release and we can rely on that?

I've made the changes to the build to use 1.6.4 instead of 1.64-SNAPSHOT.

@khatchad khatchad marked this pull request as ready for review March 28, 2024 14:08
@khatchad khatchad enabled auto-merge (squash) March 28, 2024 15:03
@khatchad khatchad merged commit eb59763 into master Mar 29, 2024
1 check passed
@khatchad khatchad deleted the update_wala branch March 29, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msridhar msridhar msridhar approved these changes

Assignees

@msridhar msridhar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khatchad @msridhar