Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnalysisScope example #11

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

AnalysisScope example #11

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eecf360
initial commit
jerryxu158 Oct 12, 2021
269c7f3
initial commit
jerryxu158 Oct 16, 2021
e49b1da
JavaDoc creation & removal of static keyword on import
jerryxu158 Oct 23, 2021
9626f97
hopefully finished the scope file example implementation
jerryxu158 Oct 25, 2021
4c2c8b4
fixed scope file input
jerryxu158 Oct 30, 2021
62d2d6d
changed param names, renamed class
jerryxu158 Nov 5, 2021
f8dbf0d
changed exception to exlcusion
jerryxu158 Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/main/java/com/ibm/wala/examples/analysisscope/analysisscope.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package com.ibm.wala.examples.analysisscope;

import com.ibm.wala.ipa.callgraph.AnalysisScope;
import com.ibm.wala.ipa.callgraph.AnalysisScope;
import com.ibm.wala.util.config.FileOfClasses;
import com.ibm.wala.util.config.AnalysisScopeReader;

import java.io.File;
import java.io.IOException;
import com.ibm.wala.util.config.AnalysisScopeReader;

//for more information, please check out https://github.com/wala/WALA/wiki/Analysis-Scope
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write this as proper Javadoc on the class rather than just a single line comment



public class analysisscope {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public class analysisscope {
public class AnalysisScopeExamples {

Class names start with a capital and use camel case. See https://google.github.io/styleguide/javaguide.html#s5.2.2-class-names

/**
* @param classPath paths of jars to include in analysis scope, formatted as a Java classpath
* @return AnaylsisScope object created by makeJavaBinaryAnalysisScope
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @return AnaylsisScope object created by makeJavaBinaryAnalysisScope
* @return AnalysisScope object created by makeJavaBinaryAnalysisScope

* @throws IOException
*/
AnalysisScope makeAnalysisScope(String classPath) throws IOException {
return AnalysisScopeReader.makeJavaBinaryAnalysisScope(classPath, null);
}

/**
*
* @param classPath Location of a scope file in string form
* @param exceptionFile location of an exception file
* @return return an analysis scope object
* @throws IOException
*/
AnalysisScope makeAnalysisScope(String classPath, String exceptionFile) throws IOException{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first parameter should be named something like scopeFilePath, and the second should be exclusionsFilePath

File exception = new File(exceptionFile);
return AnalysisScopeReader.readJavaScope(classPath, exception, null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return AnalysisScopeReader.readJavaScope(classPath, exception, null);
return AnalysisScopeReader.readJavaScope(classPath, exception, AnalysisScopeExamples.class.getClassLoader());

Should pass a real classloader as the final parameter.

}
}