Use JUnit 5 to find and run tests #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests themselves are still written using JUnit 4, so we're using JUnit 5's Vintage component to discover and run those tests. Hooray for backward compatibility! Eventually we can try porting JUnit 4 tests forward to JUnit 5, but this is a decent first step.
liblit
force-pushed
the
use-JUnit-5-dependencies
branch
from
aa18614
to
3f4be0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests themselves are still written using JUnit 4, so we're using JUnit 5's Vintage component to discover and run those tests. Hooray for backward compatibility!
Eventually we can try porting JUnit 4 tests forward to JUnit 5, but this is a decent first step.