Avoid printing many call graphs during testing #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These graph dumps add hundreds of megabytes to test logs, and presumably are manually inspected approximately never. Let's turn them off. Anyone chasing a specific bug or regression can add more debug output in their local working tree, as needed, but there's no benefit to dumping all of this data on every automated test run. Furthermore, I'm exploring an option for getting a nice test summaries after each GitHub actions workflow run. Unfortunately, the tool I am considering has some limits on the sizes `CDATA` sections it can read in JUnit's XML test logs. When our test logs include call graph dumps, several of them exceed these limits.
liblit
added a commit
to liblit/WALA
that referenced
this pull request
Jul 25, 2023
Following up wala#1294 by removing a few more rarely examined graph dumps.
liblit
added a commit
that referenced
this pull request
Jul 25, 2023
Following up #1294 by removing a few more rarely examined graph dumps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These graph dumps add hundreds of megabytes to test logs, and presumably are manually inspected approximately never. Let's turn them off. Anyone chasing a specific bug or regression can add more debug output in their local working tree, as needed, but there's no benefit to dumping all of this data on every automated test run.
Furthermore, I'm exploring an option for getting a nice test summaries after each GitHub actions workflow run. Unfortunately, the tool I am considering has some limits on the sizes
CDATAsections it can read in JUnit's XML test logs. When our test logs include call graph dumps, several of them exceed these limits.