Tag additional slow tests #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empirically, these tests start but take a long time to finish on my personal laptop. Some of them wedge the entire laptop, requiring that I cycle power to recover. Granted, my laptop is a bit old and not the most powerful. I think it's reasonable to skip a few tests to make development on this laptop feasible. We still run the full test suite, including "slow"-tagged tests, in our GitHub Actions workflows.
msridhar
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empirically, these tests start but take a long time to finish on my personal laptop. Some of them wedge the entire laptop, requiring that I cycle power to recover. Granted, my laptop is a bit old and not the most powerful. I think it's reasonable to skip a few tests to make development on this laptop feasible. We still run the full test suite, including "slow"-tagged tests, in our GitHub Actions workflows.