Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Gradle 8.3 #1310

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Upgrade to Gradle 8.3 #1310

merged 1 commit into from
Aug 20, 2023

Conversation

liblit
Copy link
Contributor

@liblit liblit commented Aug 20, 2023 •
edited
Loading

Beyond updating Gradle itself, this change required two groups of changes to our build logic:

  1. project.buildDir is deprecated. The preferred replacement is project.layout.buildDirectory, although that has a slightly different type.

  2. The configuration cache complains about using a java.net.URL as an @Input property, due to various oddities in that type's Java serialization behavior. However, java.net.URI is just fine. So our various download tasks now use URIs instead of URLs to identify the resource to be downloaded.

@liblit liblit added gradle WALA’s Gradle build system dependencies Pull requests that update a dependency file labels Aug 20, 2023
@liblit liblit self-assigned this Aug 20, 2023
@liblit liblit requested a review from msridhar August 20, 2023 01:40
@liblit liblit enabled auto-merge (rebase) August 20, 2023 01:40
@github-actions
Copy link

Test Results

   451 files  ±0     451 suites  ±0   2h 23m 35s ⏱️ - 23m 24s
   730 tests ±0     713 ✔️ ±0  17 💤 ±0  0 ❌ ±0 
2 804 runs  ±0  2 734 ✔️ ±0  70 💤 ±0  0 ❌ ±0 

Results for commit ab0655a. ± Comparison against base commit 891491c.

@liblit liblit merged commit c3f2352 into wala:master Aug 20, 2023
8 checks passed
msridhar
msridhar approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@liblit liblit deleted the Gradle-8.3 branch August 20, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msridhar msridhar msridhar approved these changes

Assignees

@liblit liblit

Labels
dependencies Pull requests that update a dependency file gradle WALA’s Gradle build system
Projects
Use Gradle configuration cache
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liblit @msridhar