-
Notifications
You must be signed in to change notification settings - Fork 24
Added a barebones GUI file selector #21
base: main
Are you sure you want to change the base?
Conversation
Added rough GUI implementation into lucasKanadeOpticalFlow.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes, approved.
Quick update, I saw CaptnBaguette post about the premade CNN yolov3 in the data-classification channel so I went ahead a made a simple example in a separate directory. |
opticalFlow/farnebackOpticalFlow.py
Outdated
The idea is that perhaps the data about how certain pixels/features are moving across the screen could be used to figure out how the player camera / aim was changing. | ||
""" | ||
|
||
from tkinter import * | ||
from tkinter import filedialog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you import all and then this separately?
Can you not just use tkinter.filedialog? Do you even need the import *?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry about that, I got lazy about my package imports.
All we need for the GUI file selector to work properly is: from tkinter import (Tk, Button, filedialog)
and from tkinter.messagebox import showinfo
. I can update the code and generate and new pull request later today when I have some time if you're cool with that.
Thanks for the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the importy's and should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I fixed the package imports. Everything should be set now.
I also removed the yolov3 code to decrease clutter. I originally included it here since the repo was pretty bare and I didn't know where else to put it. If you want to see it, it now has a home in "video.analysis" |
Just wanted to get the ball rolling with the GUI file selector. You mentioned that you wanted to eventually replace it in response the issue #16. I included here; it's pretty basic but it gets the job done.
I also was getting a
error: (-215:Assertion failed) !_src.empty() in function 'cv::cvtColor'
when running "farnebackOpticalFlow.py" so I went ahead a made some tweaks to fix the error.Hope this helps.