Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

Added a barebones GUI file selector #21

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

hilletc7
Copy link

Just wanted to get the ball rolling with the GUI file selector. You mentioned that you wanted to eventually replace it in response the issue #16. I included here; it's pretty basic but it gets the job done.

I also was getting a error: (-215:Assertion failed) !_src.empty() in function 'cv::cvtColor' when running "farnebackOpticalFlow.py" so I went ahead a made some tweaks to fix the error.

Hope this helps.

jaredb1011
jaredb1011 previously approved these changes Oct 27, 2021
Copy link
Collaborator

@jaredb1011 jaredb1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes, approved.

@hilletc7
Copy link
Author

Quick update, I saw CaptnBaguette post about the premade CNN yolov3 in the data-classification channel so I went ahead a made a simple example in a separate directory.

The idea is that perhaps the data about how certain pixels/features are moving across the screen could be used to figure out how the player camera / aim was changing.
"""

from tkinter import *
from tkinter import filedialog
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you import all and then this separately?
Can you not just use tkinter.filedialog? Do you even need the import *?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry about that, I got lazy about my package imports.
All we need for the GUI file selector to work properly is: from tkinter import (Tk, Button, filedialog) and from tkinter.messagebox import showinfo. I can update the code and generate and new pull request later today when I have some time if you're cool with that.

Thanks for the review.

Copy link
Member

@krnbrz krnbrz Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the importy's and should be good to go

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I fixed the package imports. Everything should be set now.

@hilletc7
Copy link
Author

hilletc7 commented Nov 4, 2021

I also removed the yolov3 code to decrease clutter.

I originally included it here since the repo was pretty bare and I didn't know where else to put it. If you want to see it, it now has a home in "video.analysis"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants