Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera mobs (AI eye and Blob eye) don't have shadows #336

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

Jacquerel
Copy link

@Jacquerel Jacquerel commented Aug 12, 2024

Fixes tgstation#85765
(Do cross repo links like this even work?)
(Lemon: if someone with perms on the repo in question merges it yes? I think?)

This removes the shadow from the AI and blob cursor mobs (the AI one is only visible to observers anyway IIRC).
Also removes the offset from them; they're "cursors" which are selecting floor tiles.

I was also interested in investigating "not letting you click on the shadow as a hitbox" but that doesn't seem to be a supported behaviour in BYOND.
It's not intentional for this to make mobs easier to click but... I guess it will.

Is that bad? I guess personally, while I didn't put it into the game with this intention, not really?
I have never thought pixel hunting was interesting skill expression and we're going to have swing combat eventually so maybe we just call it a feature 🙃

@ArcaneMusic
Copy link

Okay that's actually really funny

@Jacquerel
Copy link
Author

It mostly jsut annoyed ghosts because you can only see the shadow if you can see the AI eye
We should have some kind of effect which makes the ai eye permanently visible to all players in some manner because its funny

@LemonInTheDark
Copy link
Member

I was also interested in investigating "not letting you click on the shadow as a hitbox" but that doesn't seem to be a supported behaviour in BYOND.

You want mouse_opacity, but it doesn't work for overlays since they render as a part of their parent right. Solution is either use vis_contents or draw it to a separate plane (which may not be workable.
IDK this seems fine pixelhunting is cringe anyway

@Jacquerel
Copy link
Author

I was also interested in investigating "not letting you click on the shadow as a hitbox" but that doesn't seem to be a supported behaviour in BYOND.

You want mouse_opacity, but it doesn't work for overlays since they render as a part of their parent right. Solution is either use vis_contents or draw it to a separate plane (which may not be workable. IDK this seems fine pixelhunting is cringe anyway

theres the side effect that if the shadow is a convenient hitbox it will automatically encourage the behaviour of aiming guns at people's feet instead of their centre of mass and thus also reduce aiming problems <= this is a joke

@LemonInTheDark
Copy link
Member

rocks

@LemonInTheDark LemonInTheDark merged commit b2f5d21 into wall-nerds:stable Aug 12, 2024
12 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallening - Shadows are applied to things that shouldn't have them
3 participants