docs(weave): Update docs to reuse the new method for initializing the cohere_patcher #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR requires manual approval from a wandb user to run all CI checks. To see the current diff, click here. To approve CI for this PR as of this commit, comment: |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
IvanKirchev
changed the title
|
I have read the CLA Document and I hereby sign the CLA |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=546c8c1c1f5478e80259aef972e476c77e6047ac |
IvanKirchev
changed the title
Commit (wandb@adb740b) introduced a change that moved the cohere patcher initialization to a method: get_cohere_patcher. This resulted in a error accodring to the Cohere integrations docs which counted on the weave.integrations.cohere.cohere_sdk to provide "cohere_patcher" variable.
IvanKirchev
force-pushed
the
IvanKirchev/DocsFix
branch
from
1a2fa96 to
0a9f18e
Compare
|
/approve 0a9f18e |
jamie-rasmussen
approved these changes
Jan 14, 2025
|
Thank you for the excellent PR description! |
|
Our CI system doesn't work with branches in forked repos so I cloned this and merged it separately. Thank you for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the new method for initializing the cohere_patcher
What does the PR do?
This PR introduces a small change that makes use of the new method for initializing the cohere_patcher and reflects
Commit (adb740b) that moved the cohere patcher initialization to the following method: get_cohere_patcher and away from using directly the cohere_patcher variable. Without this PR if a user follows the cohere integration docs it will face the following error
ImportError: cannot import name 'cohere_patcher' from 'weave.integrations.cohere' (/usr/local/lib/python3.10/dist-packages/weave/integrations/cohere/__init__.py)Testing
How was this PR tested?
Tested locally by running the following code in a Notebook: