fix(weave): don't check non-string dict keys for sensitive key redaction #3396

jamie-rasmussen · 2025-01-14T09:39:55Z

Description

See #3379 - we were getting an AttributeError: object has no attribute 'lower' when attempting sensitive key redaction on dicts with non-str keys.

from weave.trace.weave_client import redact_sensitive_keys
d = {1: 2}
redact_sensitive_keys(d)

circle-job-mirror · 2025-01-14T09:44:30Z

andrewtruong approved these changes Jan 14, 2025

View reviewed changes

fix(weave): don't check non-string dict keys for sensitive key redaction

e2c500c

jamie-rasmussen force-pushed the jamie/dict-non-str-key-redaction branch from 7aaaeaa to e2c500c Compare January 14, 2025 16:56

jamie-rasmussen marked this pull request as ready for review January 14, 2025 17:09

jamie-rasmussen requested a review from a team as a code owner January 14, 2025 17:09

jamie-rasmussen merged commit d6017bb into master Jan 14, 2025
123 checks passed

jamie-rasmussen deleted the jamie/dict-non-str-key-redaction branch January 14, 2025 17:09

github-actions bot locked and limited conversation to collaborators Jan 14, 2025