Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppressed insertion of signature when it's nil. #26

Open
wants to merge 2 commits into
base: semi-1_14-wl
Choose a base branch
from

Conversation

jeeger
Copy link
Contributor

@jeeger jeeger commented Nov 16, 2020

This way, not even the '--' lines are inserted. This is useful for having a signature in some
folders, but none in others.

This way, not even the '--' lines are inserted. This is useful for having a signature in some
folders, but none in others.
@ikazuhiro
Copy link
Member

Please show message such as "signature not found" when signature is nil at least when called interactively.

@ikazuhiro
Copy link
Member

As far as I tested, signature never becomes nil unless I set mime-edit-default-signature to nil, which is unexpected setting. How do you reach such situation?

I can't remember details, but mime-edit-insert-signature seems to de designed always to insert signature. If you interactively call the function, it is assumed that your brain decides whether signature should be inserted. If you non-interactively call the function, wl-draft-config-alist provides such conditional calls. How is your actual usage?

@jeeger
Copy link
Contributor Author

jeeger commented Jan 11, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants