Merge pull request #156 from anoriar/validation-for-one-char-name

фамилия, имя, отчество, состоящее из одной буквы считается несклоняемым
wapmorgan · Sep 26, 2024 · cb4565d · cb4565d
2 parents 55cba44 + 0acb078
commit cb4565d
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 0 deletions.
diff --git a/src/Russian/FirstNamesInflection.php b/src/Russian/FirstNamesInflection.php
@@ -446,6 +446,10 @@ public static function getCases($name, $gender = null)
      */
     public static function isMutable($name, $gender = null)
     {
+        if (S::length($name) === 1) {
+            return false;
+        }
+
         $name = S::lower($name);
 
         if (in_array($name, static::$immutableNames, true)) {

diff --git a/src/Russian/LastNamesInflection.php b/src/Russian/LastNamesInflection.php
@@ -39,7 +39,12 @@ public static function getCase($name, $case, $gender = null)
      */
     public static function isMutable($name, $gender = null)
     {
+        if (S::length($name) === 1) {
+            return false;
+        }
+
         $name = S::lower($name);
+
         if ($gender === null) {
             $gender = static::detectGender($name);
         }

diff --git a/src/Russian/MiddleNamesInflection.php b/src/Russian/MiddleNamesInflection.php
@@ -32,7 +32,12 @@ public static function detectGender($name)
      */
     public static function isMutable($name, $gender = null)
     {
+        if (S::length($name) === 1) {
+            return false;
+        }
+
         $name = S::lower($name);
+
         if (in_array(S::slice($name, -2), ['ич', 'на'], true)) {
             return true;
         }

diff --git a/tests/Russian/FirstNamesInflecionTest.php b/tests/Russian/FirstNamesInflecionTest.php
@@ -730,6 +730,7 @@ public function immutableNamesProvider()
             ['Грегори', FirstNamesInflection::MALE],
             ['Гиви', FirstNamesInflection::MALE],
             ['Франсуа', FirstNamesInflection::MALE],
+            ['А', NamesInflection::FEMALE],
         ];
     }
 

diff --git a/tests/Russian/LastNamesInflectionTest.php b/tests/Russian/LastNamesInflectionTest.php
@@ -117,6 +117,7 @@ public function immutableNamesProvider()
             ['Хитрово', NamesInflection::MALE],
             ['Бози', NamesInflection::MALE],
             ['Цой', NamesInflection::FEMALE],
+            ['А', NamesInflection::FEMALE],
         ];
     }
 }
diff --git a/tests/Russian/MiddleNamesInflectionTest.php b/tests/Russian/MiddleNamesInflectionTest.php
@@ -4,6 +4,7 @@
 
 use morphos\NamesInflection;
 use morphos\Russian\Cases;
+use morphos\Russian\LastNamesInflection;
 use morphos\Russian\MiddleNamesInflection;
 use PHPUnit\Framework\TestCase;
 
@@ -90,4 +91,19 @@ public function testGetCase($name, $gender, $case2)
     {
         $this->assertEquals($case2, MiddleNamesInflection::getCase($name, Cases::RODIT, $gender));
     }
+
+    /**
+     * @dataProvider immutableNamesProvider()
+     */
+    public function testImmutable($name, $gender)
+    {
+        $this->assertFalse(MiddleNamesInflection::isMutable($name, $gender));
+    }
+
+    public function immutableNamesProvider()
+    {
+        return [
+            ['А', NamesInflection::FEMALE],
+        ];
+    }
 }