Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Surface::present() errors non-fatal. #2

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

vorporeal
Copy link

Description

WISOTT.

We need this in order to be able to catch device loss errors using an error scope and handle them gracefully.

Testing

  • Tested by adding the following code at the start of present() that unconditionally produces a DeviceError::Lost and verified that Warp will detect it and try to recreate the renderer.
let error = SurfaceError::Device(wgc::device::DeviceError::Lost);
self.context
    .handle_error_nolabel(&self.error_sink, error, "Surface::present");

@vorporeal vorporeal requested a review from acarl005 February 20, 2025 17:11
@vorporeal vorporeal merged commit 58b2f07 into warpdotdev/v24 Feb 20, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants