-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home Screen: Get medications for the selected date from DB instead of filtering #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me! 🚀 I just had some minor comments.
app/src/main/java/com/waseefakhtar/doseapp/extension/DateExtension.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/waseefakhtar/doseapp/feature/home/viewmodel/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
…sion.kt Co-authored-by: Waseef Akhtar <[email protected]>
Addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @daniel-waiguru! 👏 Sorry I couldn't review this sooner but thank you for your contribution! :)
This pull request contains the following changes:
Please review the changes and let me know if you have any questions.
Closes #114