Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding-navigate-single-top-to-navHostController #72

Merged
merged 6 commits into from
Oct 14, 2023
Merged

adding-navigate-single-top-to-navHostController #72

merged 6 commits into from
Oct 14, 2023

Conversation

Kayvee08
Copy link
Contributor

@Kayvee08 Kayvee08 commented Oct 9, 2023

Adding link to the issue :- #65

waseefakhtar
waseefakhtar reviewed Oct 9, 2023
View reviewed changes
Copy link
Owner

@waseefakhtar waseefakhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @Kayvee08! The only issue now is that ASK_NOTIFICATION_PERMISSION is not passed to the next screen since there's no back stack: https://github.com/waseefakhtar/dose-android/pull/72/files#diff-45cc24ad02e2857fe4dafd267f0d8d8368ad2d362c1832b11a3a0929cbf7ad0dL55. Can you look into that?

We retrieve the value of ASK_NOTIFICATION_PERMISSION in HomeDestination.NavGraphBuilder.homeGraph and ask for notification permission in Android 13 after the medication is added to DB successfully.

@waseefakhtar waseefakhtar added the bug Something isn't working label Oct 14, 2023
@waseefakhtar waseefakhtar added this to the 1.0 milestone Oct 14, 2023
@waseefakhtar
Copy link
Owner

waseefakhtar commented Oct 14, 2023 •
edited
Loading

This looks good @Kayvee08! The only issue now is that ASK_NOTIFICATION_PERMISSION is not passed to the next screen since there's no back stack: https://github.com/waseefakhtar/dose-android/pull/72/files#diff-45cc24ad02e2857fe4dafd267f0d8d8368ad2d362c1832b11a3a0929cbf7ad0dL55. Can you look into that?

We retrieve the value of ASK_NOTIFICATION_PERMISSION in HomeDestination.NavGraphBuilder.homeGraph and ask for notification permission in Android 13 after the medication is added to DB successfully.

@Kayvee08 I just added a fix for this. So we're all good now.

waseefakhtar
waseefakhtar approved these changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@waseefakhtar waseefakhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution @Kayvee08! :)

@waseefakhtar waseefakhtar merged commit 34525f8 into waseefakhtar:main Oct 14, 2023
@waseefakhtar waseefakhtar mentioned this pull request Oct 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waseefakhtar waseefakhtar waseefakhtar approved these changes

Assignees

@Kayvee08 Kayvee08

Labels
bug Something isn't working
Projects
Dose App
Status: Ready 🚀
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Kayvee08 @waseefakhtar