-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route warnings to our logs #148
Conversation
PR #146 👋🏻 |
I'm confused about this. We were able to see warnings in the logs previously, weren't we? |
I don't think we were seeing them unless we explicitly did |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, that makes sense. thanks for finding.
Anytime! Logging is so annoying lol 😬 |
@@ -18,7 +18,8 @@ | |||
"handlers": ["default"], | |||
"level": "INFO", | |||
"propagate": True, | |||
} | |||
}, | |||
"py.warnings": {"handlers": ["default"], "level": "INFO", "propigate": True}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo for propagate here
Description
Hi! The changes in this PR ensure that warnings appear in our logs. With
logging.captureWarnings(True)
, Python creates a new logger calledpy.warnings
and sends all of the warning messages there. The change in this PR will make sure messages on thepy.warnings
logger also appear alongside ourelexmodel
logger messages 🎉Jira Ticket
Test Steps
Try this on
develop
and then on this branch:😅