Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stdout/stderr output #360

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Improve stdout/stderr output #360

merged 2 commits into from
Dec 13, 2023

Conversation

syrusakbary
Copy link
Member

This PR improves the Output of .wait() by renaming the variables for convenience of usage:

  • stdout -> stdoutBytes
  • stdoutUtf8 -> stdout
  • stderr -> stderrBytes
  • stderrUtf8 -> stderr

Michael-F-Bryan
Michael-F-Bryan approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Michael-F-Bryan Michael-F-Bryan merged commit 739336b into main Dec 13, 2023
5 checks passed
@Michael-F-Bryan Michael-F-Bryan deleted the stdoutBytes branch December 13, 2023 06:53
@github-actions GitHub Actions
Copy link

⏱ Workflow Timer ⏱

Make sure you keep an eye on build times!

The goal is to keep CI times under 10 minutes so developers can maintain a fast edit-compile-test cycle.

Run Compile and Test Build Examples
main 7mins 14s 3mins 46s
593443f 6mins 42s 3mins 51s

🤖 Beep. Boop. I'm a bot. If you find any issues, please report them to https://github.com/Michael-F-Bryan/workflow-timer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syrusakbary @Michael-F-Bryan