Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for examples #381

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Fix CI for examples #381

merged 4 commits into from
Dec 21, 2023

Conversation

Michael-F-Bryan
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan commented Dec 21, 2023

It looks like CI for building the examples is failing as of #361, but because that job wasn't set as a "required" job, auto-merge merged the PR anyway.

I believe the root cause is that we're using node v16 in CI, but esbuild requires at least v18.

npm WARN cleanup Failed to remove some directories [
npm WARN cleanup   [
npm WARN cleanup     '/home/runner/work/wasmer-js/wasmer-js/examples/ffmpeg-react/node_modules',
npm WARN cleanup     [Error: ENOTEMPTY: directory not empty, rmdir '/home/runner/work/wasmer-js/wasmer-js/examples/ffmpeg-react/node_modules/@swc/core'] {
npm WARN cleanup       errno: -39,
npm WARN cleanup       code: 'ENOTEMPTY',
npm WARN cleanup       syscall: 'rmdir',
npm WARN cleanup       path: '/home/runner/work/wasmer-js/wasmer-js/examples/ffmpeg-react/node_modules/@swc/core'
npm WARN cleanup     }
npm WARN cleanup   ],
npm WARN cleanup   [
npm WARN cleanup     '/home/runner/work/wasmer-js/wasmer-js/examples/ffmpeg-react/node_modules/@swc',
npm WARN cleanup     [Error: ENOTEMPTY: directory not empty, rmdir '/home/runner/work/wasmer-js/wasmer-js/examples/ffmpeg-react/node_modules/@swc/core'] {
npm WARN cleanup       errno: -39,
npm WARN cleanup       code: 'ENOTEMPTY',
npm WARN cleanup       syscall: 'rmdir',
npm WARN cleanup       path: '/home/runner/work/wasmer-js/wasmer-js/examples/ffmpeg-react/node_modules/@swc/core'
npm WARN cleanup     }
npm WARN cleanup   ]
npm WARN cleanup ]
npm ERR! code 1
npm ERR! path /home/runner/work/wasmer-js/wasmer-js/examples/ffmpeg-react/node_modules/esbuild
npm ERR! command failed
npm ERR! command sh -c node install.js
npm ERR! /home/runner/work/wasmer-js/wasmer-js/examples/ffmpeg-react/node_modules/esbuild/install.js:133
npm ERR!     throw new Error(`Expected ${JSON.stringify(versionFromPackageJSON)} but got ${JSON.stringify(stdout)}`);
npm ERR!           ^
npm ERR! 
npm ERR! Error: Expected "0.19.10" but got "0.19.9"
npm ERR!     at validateBinaryVersion (/home/runner/work/wasmer-js/wasmer-js/examples/ffmpeg-react/node_modules/esbuild/install.js:133:11)
npm ERR!     at /home/runner/work/wasmer-js/wasmer-js/examples/ffmpeg-react/node_modules/esbuild/install.js:286:5

@Michael-F-Bryan Michael-F-Bryan marked this pull request as ready for review December 21, 2023 01:43
@Michael-F-Bryan Michael-F-Bryan merged commit 795b2af into main Dec 21, 2023
5 checks passed
@Michael-F-Bryan Michael-F-Bryan deleted the fix-examples-ci branch December 21, 2023 10:36
Copy link

⏱ Workflow Timer ⏱

Make sure you keep an eye on build times!

The goal is to keep CI times under 10 minutes so developers can maintain a fast edit-compile-test cycle.

Run Compile and Test Build Examples
main 6mins 16s 3mins 44s
675c77b 5mins 55s 4mins 2s

🤖 Beep. Boop. I'm a bot. If you find any issues, please report them to https://github.com/Michael-F-Bryan/workflow-timer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants