Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid debug_assert #835

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Fix invalid debug_assert #835

merged 5 commits into from
Dec 5, 2023

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Dec 5, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fdd9364) 80.95% compared to head (b3f0de6) 81.03%.

Files Patch % Lines
crates/wasmi/src/engine/bytecode/construct.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
+ Coverage   80.95%   81.03%   +0.07%     
==========================================
  Files         257      257              
  Lines       22472    22446      -26     
==========================================
- Hits        18192    18188       -4     
+ Misses       4280     4258      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
br_table
1.46ms 1.49ms 🔴 2.03% 1.33ms 1.32ms ⚪ -1.09% 🟢 -12%
execute/
call/host/1
47.04µs 46.53µs ⚪ -0.86% 65.11µs 64.37µs ⚪ -1.08% 🟢 38%
execute/
call/rec
168.92µs 166.68µs 🟢 -3.58% 360.15µs 352.23µs 🟢 -2.21% 🔴 111%
execute/
count_until
7.48ms 7.42ms ⚪ -1.00% 7.51ms 7.49ms ⚪ -0.33% 🟢 1%
execute/
divrem
6.26ms 6.26ms ⚪ 0.07% 7.53ms 6.97ms 🟢 -7.53% 🟢 11%
execute/
factorial/iter
218.20µs 216.08µs ⚪ -0.87% 314.68µs 300.73µs 🟢 -4.35% 🟢 39%
execute/
factorial/rec
682.07µs 683.07µs ⚪ -0.02% 1.32ms 1.28ms 🟢 -2.86% 🟡 88%
execute/
fibonacci/iter
1.36ms 1.36ms ⚪ -0.03% 1.26ms 1.27ms ⚪ 0.47% 🟢 -7%
execute/
fibonacci/rec
6.08ms 6.15ms ⚪ 0.98% 13.14ms 13.08ms ⚪ -0.52% 🔴 113%
execute/
fibonacci/tail
1.35ms 1.37ms ⚪ 1.12% 3.86ms 3.62ms 🟢 -6.46% 🔴 165%
execute/
fuse
7.35ms 8.17ms 🔴 11.22% 11.41ms 11.70ms 🔴 2.49% 🟢 43%
execute/
global/bump
1.34ms 1.32ms ⚪ -0.50% 1.54ms 1.54ms ⚪ 0.00% 🟢 17%
execute/
global/get_const
728.31µs 747.77µs ⚪ 1.37% 750.59µs 750.41µs ⚪ 0.04% 🟢 0%
execute/
is_even/rec
1.08ms 1.06ms 🟢 -2.16% 2.25ms 2.23ms 🟢 -1.84% 🔴 111%
execute/
memory/fill_bytes
1.14ms 1.13ms ⚪ -0.47% 1.32ms 1.31ms ⚪ -0.45% 🟢 16%
execute/
memory/sum_bytes
1.09ms 1.15ms 🔴 5.54% 1.25ms 1.23ms 🟢 -1.76% 🟢 7%
execute/
memory/vec_add
2.96ms 2.97ms ⚪ -0.02% 3.61ms 3.61ms ⚪ 0.13% 🟢 22%
execute/
recursive_scan
187.46µs 185.61µs ⚪ -0.98% 393.62µs 380.67µs 🟢 -3.24% 🔴 105%
execute/
recursive_trap
15.41µs 15.32µs ⚪ -0.73% 36.71µs 34.14µs 🟢 -7.01% 🔴 123%
execute/
regex_redux
596.44µs 594.25µs ⚪ -0.24% 1.10ms 1.06ms 🟢 -3.76% 🟡 78%
execute/
rev_complement
443.57µs 442.93µs ⚪ -0.13% 678.89µs 628.25µs 🟢 -7.50% 🟢 42%
execute/
tiny_keccak
350.10µs 353.14µs ⚪ 2.26% 381.94µs 383.97µs ⚪ 0.50% 🟢 9%
execute/
trunc_f2i
630.82µs 617.52µs ⚪ -2.02% 961.10µs 953.76µs ⚪ -0.84% 🟡 54%
instantiate/
wasm_kernel
55.21µs 52.31µs 🟢 -5.44% 53.69µs 56.83µs 🔴 5.88% 🟢 9%
overhead/
call/typed/0
1.21ms 1.21ms ⚪ -0.15% 773.12µs 842.69µs 🔴 8.91% 🟢 -30%
overhead/
call/typed/16
1.60ms 1.74ms 🔴 8.93% 1.87ms 1.90ms 🔴 1.66% 🟢 9%
overhead/
call/untyped/0
1.60ms 1.67ms 🔴 3.95% 1.20ms 1.30ms 🔴 7.98% 🟢 -22%
overhead/
call/untyped/16
2.53ms 2.64ms 🔴 4.06% 4.02ms 4.04ms ⚪ 0.45% 🟡 53%
translate/
bz2/checked/default
1.38ms 1.38ms ⚪ -0.08% 2.81ms 2.56ms 🟢 -8.98% 🟡 85%
translate/
bz2/checked/fuel
1.42ms 1.43ms ⚪ 0.21% 2.95ms 2.66ms 🟢 -9.80% 🟡 87%
translate/
bz2/unchecked/default
1.12ms 1.11ms ⚪ -0.43% 2.08ms 1.95ms 🟢 -6.48% 🟡 75%
translate/
bz2/unchecked/fuel
1.16ms 1.16ms ⚪ -0.26% 2.20ms 2.08ms 🟢 -5.74% 🟡 79%
translate/
erc1155/checked/default
282.18µs 282.08µs ⚪ 0.16% 527.18µs 488.35µs 🟢 -7.32% 🟡 73%
translate/
erc1155/checked/fuel
300.22µs 301.25µs ⚪ 0.02% 555.85µs 514.39µs 🟢 -7.36% 🟡 71%
translate/
erc1155/unchecked/default
232.66µs 231.71µs ⚪ 0.15% 405.22µs 383.28µs 🟢 -5.23% 🟡 65%
translate/
erc1155/unchecked/fuel
252.30µs 250.41µs ⚪ -0.63% 429.33µs 409.22µs 🟢 -4.59% 🟡 63%
translate/
erc20/checked/default
136.95µs 137.99µs ⚪ 1.01% 252.70µs 234.95µs 🟢 -6.98% 🟡 70%
translate/
erc20/checked/fuel
144.81µs 145.03µs ⚪ 0.15% 261.60µs 244.97µs 🟢 -6.25% 🟡 69%
translate/
erc20/unchecked/default
112.81µs 112.83µs ⚪ -0.01% 195.16µs 186.52µs 🟢 -4.51% 🟡 65%
translate/
erc20/unchecked/fuel
120.09µs 119.56µs ⚪ -0.52% 203.34µs 202.10µs ⚪ -0.74% 🟡 69%
translate/
erc721/checked/default
193.62µs 196.48µs 🔴 1.87% 366.89µs 340.53µs 🟢 -7.11% 🟡 73%
translate/
erc721/checked/fuel
203.77µs 203.71µs ⚪ 0.73% 379.66µs 352.74µs 🟢 -7.13% 🟡 73%
translate/
erc721/unchecked/default
157.87µs 158.29µs ⚪ 1.01% 285.33µs 262.43µs 🟢 -7.77% 🟡 66%
translate/
erc721/unchecked/fuel
169.64µs 167.15µs ⚪ -1.22% 296.29µs 279.51µs 🟢 -5.89% 🟡 67%
translate/
pulldown_cmark/checked/default
3.81ms 3.75ms ⚪ -1.33% 7.08ms 6.55ms 🟢 -7.38% 🟡 75%
translate/
pulldown_cmark/checked/fuel
3.89ms 3.86ms ⚪ -0.92% 7.41ms 6.83ms 🟢 -7.98% 🟡 77%
translate/
pulldown_cmark/unchecked/default
3.14ms 3.09ms ⚪ -1.28% 5.37ms 5.11ms 🟢 -5.07% 🟡 65%
translate/
pulldown_cmark/unchecked/fuel
3.23ms 3.21ms ⚪ 0.32% 5.61ms 5.34ms 🟢 -4.64% 🟡 66%
translate/
spidermonkey/checked/default
0.00ns 0.00ns ⚪ -0.19% 0.00ns 0.00ns 🟢 -7.79% 🟢 0%
translate/
spidermonkey/checked/fuel
0.00ns 0.00ns ⚪ -0.88% 0.00ns 0.00ns 🟢 -10.45% 🟢 0%
translate/
spidermonkey/unchecked/default
72.09ms 71.98ms ⚪ -1.16% 0.00ns 0.00ns 🟢 -3.18% 🟢 -100%
translate/
spidermonkey/unchecked/fuel
0.00ns 0.00ns ⚪ -0.26% 0.00ns 0.00ns 🟢 -5.03% 🟢 0%
translate/
wasm_kernel/checked/default
5.07ms 5.09ms ⚪ -0.30% 9.44ms 8.88ms 🟢 -6.09% 🟡 74%
translate/
wasm_kernel/checked/fuel
5.21ms 5.20ms ⚪ -0.23% 9.87ms 9.21ms 🟢 -6.49% 🟡 77%
translate/
wasm_kernel/unchecked/default
4.09ms 4.10ms ⚪ 0.63% 7.17ms 6.86ms 🟢 -4.37% 🟡 67%
translate/
wasm_kernel/unchecked/fuel
4.22ms 4.21ms ⚪ -0.74% 7.47ms 7.18ms 🟢 -3.90% 🟡 71%

Link to pipeline

@Robbepop Robbepop merged commit 38c968e into master Dec 5, 2023
15 checks passed
@Robbepop Robbepop deleted the rf-fix-invalid-debug-assert branch December 5, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants