Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease sample_size for translation test cases #837

Closed
wants to merge 1 commit into from

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Dec 6, 2023

This could potentially fix CI translation benchmark results display for spidermonkey test cases.

This could potentially fix CI translation benchmark results display for spidermonkey test cases.
@Robbepop
Copy link
Member Author

Robbepop commented Dec 6, 2023

Experiment failed since Criterion hardcodes sample_size to be at least 10.

thread 'main' panicked at 'assertion failed: n >= 10', /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/criterion-0.5.1/src/lib.rs:527:9

@Robbepop Robbepop closed this Dec 6, 2023
@Robbepop Robbepop deleted the rf-try-fix-translation-bench-ci branch March 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant